Skip to content

Merge release #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 3, 2014
Merged

Merge release #159

merged 5 commits into from
Dec 3, 2014

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Dec 2, 2014

ErjanGavalji and others added 5 commits November 12, 2014 13:55
Change default profile-dir to be:
 - %localappdata%\.nativescript-cli for Windows
 - ~/.local/share/.nativescript-cli for MacOS and Linux

Update common lib where the following change is applied: DefaultValue is passed to the setProfileDir method. Different CLI-s have different defaultProfileDirs. setProfileDir method will use the passed on the command line profile-dir or the default one passed as parameter to the function.
Add implementation of IOptionsService interface with one method - getKnownOptions. This method is used in commands service in order to get full list of supported -- options. As each CLI have its own list of knownOptions and the mobile lib has only some of them, the implementation of the interface has to be outside of the lib. This way we can use autocomplete for all available options, not only for the common ones.
Change dependency of xmlhttprequest to use Telerik fork.

Update common lib, where the following change is applied: EqatecMonitor.js call setTimeout of XMLHttpRequest with default value - 10000 ms. Add SetRequestTimeout method to EqatecMonitor which sets global timeout variable (currently this method is not used).

The timeout is required in order to prevent console hanging when analytics cannot send the request.
@ns-bot
Copy link

ns-bot commented Dec 2, 2014

Test PASSed.

@teobugslayer
Copy link
Contributor

👍

Fatme pushed a commit that referenced this pull request Dec 3, 2014
@Fatme Fatme merged commit 676f12e into master Dec 3, 2014
@Fatme Fatme deleted the fatme/merge-release branch December 3, 2014 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants